feat: Preserve parameter data types for variable references in Expression Language#842
Open
BackendBits wants to merge 2 commits intomainfrom
Open
feat: Preserve parameter data types for variable references in Expression Language#842BackendBits wants to merge 2 commits intomainfrom
BackendBits wants to merge 2 commits intomainfrom
Conversation
5bf4fbb to
22d55d1
Compare
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
22d55d1 to
a182898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Preserve original data types for parameters that directly reference other parameters, instead of converting them to
String.If a parameter is a simple reference like
${MONGO_DB_PORT}or$MONGO_DB_PORTand the target value is anInteger,Long, orBoolean, the referencing parameter now keeps that type. Existing string/template behavior is unchanged.Issue
No existing GitHub issue.
This is needed because direct references (e.g.
DUMPS_MONGO_PORT: ${MONGO_DB_PORT}) were previously turned into strings, which can break schema validation and consumers expecting numeric/boolean values.Breaking Change?
Behavior only changes for simple references to non-String values, and is backwards-compatible for all other cases.
Scope / Project
build_effective_set_generator_javaparameters-processorImplementation Notes
${VAR},$VAR,<% VAR %>) and, when they resolve to a non-String value, return a new Parameter wrapping that value without going through template/string processing.Stringvalues, avoiding unintended conversion of numeric/boolean values to strings.Tests / Evidence
${VAR}and$VAR.parameters-processorpass (ExpressionLanguageTest and related suites).27017,true,604800000) instead of quoted strings in the generated deployment-parameters.yaml.Additional Notes
None.